LayoutTests/media/video-controls-always-visible-when-control-hovered.html - Issue 441193003: Hide video controls after touch when hideMediaControlsTimerFired fires.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/media/video-controls-always-visible-when-control-hovered.html

Issue 441193003: Hide video controls after touch when hideMediaControlsTimerFired fires. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add bug number to comment Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/media/media-controls.js ('k') | LayoutTests/media/video-controls-always-visible-when-control-hovered-expected.txt » ('j') | LayoutTests/media/video-controls-hide-after-touch-on-control.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/media/video-controls-always-visible-when-control-hovered.html

diff --git a/LayoutTests/media/video-controls-hide-on-move-outside-controls.html b/LayoutTests/media/video-controls-always-visible-when-control-hovered.html

similarity index 77%

copy from LayoutTests/media/video-controls-hide-on-move-outside-controls.html

copy to LayoutTests/media/video-controls-always-visible-when-control-hovered.html

index bbd27246f8be2dbc2a2796618cdb0ae7283f0646..68162418d20aad1b36112dd10f7aec668bd6bc40 100644

--- a/LayoutTests/media/video-controls-hide-on-move-outside-controls.html

+++ b/LayoutTests/media/video-controls-always-visible-when-control-hovered.html

@@ -29,21 +29,20 @@ function runTest()

eventSender.mouseUp();

testExpected("video.paused", false);

- runAfterControlsHidden(function()

+ runAfterHideMediaControlsTimerFired(function()

Ignacio Solla 2014/08/06 19:05:56 Note that this is a new file, but for some reason

{

controls = mediaControlsButton(video, "panel");

- testExpected("getComputedStyle(controls).opacity", 0);

+ testExpected("getComputedStyle(controls).opacity", 1);

consoleWrite("");

endTest();

}, video);

- // Move the mouse to the upper-left corner of the video.

- eventSender.mouseMoveTo(video.offsetLeft + 4, video.offsetTop + 4);

}

</script>

<body>

- Test video element control visibility when mouse is not over element.

+ Test video element control visibility after click on control. After the click

+ the mouse does not move, so the control is still hovered and it should

+ remain visible.

This test only runs in DRT!