Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 441143002: Revert 287581 "Allow recommended locales to be set for public se..." (Closed)

Created:
6 years, 4 months ago by robliao
Modified:
6 years, 4 months ago
Reviewers:
bartfab (slow)
CC:
chromium-reviews, Ryan Hamilton
Visibility:
Public.

Description

Revert 287581 "Allow recommended locales to be set for public se..." AddressSanitizer: global-buffer-overflow READ of size 8 at 0x0000155dfc10 thread T0 (browser_tests) #0 0xda3a92 in policy::DeviceLocalAccountTest::SetRecommendedLocales(char const**, unsigned long) chrome/browser/chromeos/policy/device_local_account_browsertest.cc:583:7 #1 0xdaa280 in policy::DeviceLocalAccountTest_MultipleRecommendedLocales_Test::RunTestOnMainThread() chrome/browser/chromeos/policy/device_local_account_browsertest.cc:1671:3 #2 0x38ea263 in InProcessBrowserTest::RunTestOnMainThreadLoop() chrome/test/base/in_process_browser_test.cc:428:5 > Allow recommended locales to be set for public sessions > > This CL introduces the |SessionLocales| policy that can be used to > recommend one or more UI locales for a public session. If the policy is > set, the first recommended locale is pre-selected when starting a public > session. If more than one locale is recommended, the public session pod > is shown in its advanced form, highlighting the availability of language > and keyboard layout pickers. > > The keyboard layout is automatically set to the most popular layout > matching the UI locale. > > BUG=214904, 241790 > TEST=Extensive browser test coverage, including picker UI > R=asvitkine@chromium.org, nkostylev@chromium.org, pneubeck@chromium.org > > Review URL: https://codereview.chromium.org/426063005 TBR=bartfab@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287634

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -1055 lines) Patch
M trunk/src/chrome/browser/chromeos/login/app_launch_signin_screen.cc View 1 chunk +1 line, -6 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/login/existing_user_controller.h View 2 chunks +0 lines, -15 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc View 6 chunks +7 lines, -91 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/login/screens/chrome_user_selection_screen.h View 2 chunks +0 lines, -12 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc View 4 chunks +0 lines, -88 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/login/screens/user_selection_screen.h View 3 chunks +0 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/login/screens/user_selection_screen.cc View 7 chunks +22 lines, -67 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 31 chunks +111 lines, -550 lines 0 comments Download
M trunk/src/chrome/browser/policy/configuration_policy_handler_list_factory.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/chromeos/login/l10n_util.cc View 1 chunk +1 line, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h View 3 chunks +2 lines, -12 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 2 chunks +5 lines, -19 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/test/data/policy/policy_test_cases.json View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/components/policy/resources/policy_templates.json View 2 chunks +1 line, -35 lines 0 comments Download
M trunk/src/tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ui/login/account_picker/screen_account_picker.js View 2 chunks +2 lines, -23 lines 0 comments Download
M trunk/src/ui/login/account_picker/user_pod_row.js View 6 chunks +38 lines, -111 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
robliao
6 years, 4 months ago (2014-08-05 23:09:56 UTC) #1
robliao
Committed patchset #1 manually as r287634.
6 years, 4 months ago (2014-08-05 23:10:09 UTC) #2
robliao
6 years, 4 months ago (2014-08-05 23:11:12 UTC) #3
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698