Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 441133002: Add a landmine to fix builders after blink_resources.grd changed (Closed)

Created:
6 years, 4 months ago by eseidel
Modified:
6 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews, Ken Russell (switch to Gerrit), tfarina, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a landmine to fix builders after blink_resources.grd changed I will send a PSA to chromium-dev shortly explaining the issue. BUG=338338, 400860 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287640

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/get_landmines.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
eseidel
6 years, 4 months ago (2014-08-05 23:08:03 UTC) #1
Nico
lgtm
6 years, 4 months ago (2014-08-05 23:15:56 UTC) #2
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 4 months ago (2014-08-05 23:18:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/441133002/1
6 years, 4 months ago (2014-08-05 23:19:26 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 23:21:59 UTC) #5
Message was sent while issue was closed.
Change committed as 287640

Powered by Google App Engine
This is Rietveld 408576698