Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 441123002: Creates a dummy view to occupy the logo area of athena home card. (Closed)

Created:
6 years, 4 months ago by Jun Mukai
Modified:
6 years, 4 months ago
Reviewers:
oshima
CC:
chromium-reviews, hashimoto, Matt Giuca
Project:
chromium
Visibility:
Public.

Description

Creates a dummy view to occupy the logo area of athena home card. As is discussed in the bug, it is important to occupy certain area for logo mark in the home card, otherwise the area for the search results is restricted. Actual experimental app-list uses start_page webview for this, which embeds the logo from our resource data. I think it's better to create a dummy view with flat background instead of loading the resource image to emphasize this is still work-in-progress. BUG=400153 R=oshima@chromium.org TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288199

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M athena/home/app_list_view_delegate.cc View 1 2 chunks +27 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Jun Mukai
6 years, 4 months ago (2014-08-06 17:38:42 UTC) #1
oshima
lgtm with nits https://codereview.chromium.org/441123002/diff/1/athena/home/app_list_view_delegate.cc File athena/home/app_list_view_delegate.cc (right): https://codereview.chromium.org/441123002/diff/1/athena/home/app_list_view_delegate.cc#newcode44 athena/home/app_list_view_delegate.cc:44: gfx::Size size_; const https://codereview.chromium.org/441123002/diff/1/athena/home/app_list_view_delegate.cc#newcode45 athena/home/app_list_view_delegate.cc:45: }; ...
6 years, 4 months ago (2014-08-07 06:37:48 UTC) #2
Jun Mukai
https://codereview.chromium.org/441123002/diff/1/athena/home/app_list_view_delegate.cc File athena/home/app_list_view_delegate.cc (right): https://codereview.chromium.org/441123002/diff/1/athena/home/app_list_view_delegate.cc#newcode44 athena/home/app_list_view_delegate.cc:44: gfx::Size size_; On 2014/08/07 06:37:48, oshima wrote: > const ...
6 years, 4 months ago (2014-08-07 20:14:34 UTC) #3
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 4 months ago (2014-08-07 20:14:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/441123002/20001
6 years, 4 months ago (2014-08-07 20:18:58 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 01:38:25 UTC) #6
Message was sent while issue was closed.
Change committed as 288199

Powered by Google App Engine
This is Rietveld 408576698