Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: chrome/browser/extensions/api/copresence/copresence_api.cc

Issue 441103002: Tests for the Copresence API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@api
Patch Set: "Assertions" cleanup Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/copresence/copresence_api.cc
diff --git a/chrome/browser/extensions/api/copresence/copresence_api.cc b/chrome/browser/extensions/api/copresence/copresence_api.cc
index 53ab40134f194f822011a7c70ca6299441301255..149b5ddd4741e8d7d95b49d8e61e3dcd8382e2b0 100644
--- a/chrome/browser/extensions/api/copresence/copresence_api.cc
+++ b/chrome/browser/extensions/api/copresence/copresence_api.cc
@@ -41,8 +41,9 @@ CopresenceService::~CopresenceService() {
}
copresence::CopresenceClient* CopresenceService::client() {
- if (!client_)
- client_.reset(new copresence::CopresenceClient(this));
+ if (!client_) {
+ client_ = copresence::CopresenceClient::Create(this);
+ }
return client_.get();
}
@@ -57,6 +58,11 @@ void CopresenceService::Shutdown() {
client_->Shutdown();
}
+void CopresenceService::set_client_for_testing(
+ scoped_ptr<copresence::CopresenceClient> client) {
+ client_ = client.Pass();
+}
+
// static
BrowserContextKeyedAPIFactory<CopresenceService>*
CopresenceService::GetFactoryInstance() {
@@ -111,7 +117,7 @@ const std::string CopresenceService::GetPlatformVersionString() const {
}
copresence::WhispernetClient* CopresenceService::GetWhispernetClient() {
- return whispernet_client_.get();
+ return whispernet_client();
}
template <>

Powered by Google App Engine
This is Rietveld 408576698