chrome/browser/extensions/api/copresence/copresence_translations.cc - Issue 441103002: Tests for the Copresence API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/copresence/copresence_translations.cc

Issue 441103002: Tests for the Copresence API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@api

Patch Set: Fixing tests Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/copresence/copresence_api_unittest.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | components/copresence/public/copresence_manager_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/copresence/copresence_translations.cc

diff --git a/chrome/browser/extensions/api/copresence/copresence_translations.cc b/chrome/browser/extensions/api/copresence/copresence_translations.cc

index 5981939389f8d9bbc901a2da8074ba3b14a5eef0..d7d80568761091d24ee3756deef531622b0d2d6b 100644

--- a/chrome/browser/extensions/api/copresence/copresence_translations.cc

+++ b/chrome/browser/extensions/api/copresence/copresence_translations.cc

@@ -130,7 +130,7 @@ bool AddSubscribeToRequest(

return false;

}

- // Convert from client to server subscription format.

+ // Convert from IDL to server subscription format.

copresence::Subscription* subscription_proto =

request->mutable_manage_subscriptions_request()->add_subscription();

subscription_proto->set_id(subscription.id);