Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1261)

Issue 4411002: Remove FileRef, FileIO and DirectoryReader PPAPI tests from ui_tests... (Closed)

Created:
10 years, 1 month ago by dumi
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove FileRef, FileIO and DirectoryReader PPAPI tests from ui_tests for now. It looks like run_testserver is crashing. BUG=none TEST=none TBR=darin Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65008

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M chrome/test/ui/ppapi_uitest.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dumi
10 years, 1 month ago (2010-11-04 01:08:28 UTC) #1
darin (slow to review)
10 years, 1 month ago (2010-11-04 16:39:45 UTC) #2
OK, marking them DISABLED is usually preferred.

-Darin


On Wed, Nov 3, 2010 at 6:08 PM, <dumi@chromium.org> wrote:

> Reviewers: darin,
>
> Description:
> Remove FileRef, FileIO and DirectoryReader PPAPI tests from ui_tests
> for now. It looks like run_testserver is crashing.
>
> BUG=none
> TEST=none
> TBR=darin
>
>
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65008
>
> Please review this at http://codereview.chromium.org/4411002/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/test/ui/ppapi_uitest.cc
>
>
> Index: chrome/test/ui/ppapi_uitest.cc
> ===================================================================
> --- chrome/test/ui/ppapi_uitest.cc      (revision 65006)
> +++ chrome/test/ui/ppapi_uitest.cc      (working copy)
> @@ -135,15 +135,3 @@
>  TEST_F(PPAPITest, Var) {
>   RunTest("Var");
>  }
> -
> -TEST_F(PPAPITest, FileRef) {
> -  RunTestViaHTTP("FileRef");
> -}
> -
> -TEST_F(PPAPITest, FileIO) {
> -  RunTestViaHTTP("FileIO");
> -}
> -
> -TEST_F(PPAPITest, DirectoryReader) {
> -  RunTestViaHTTP("DirectoryReader");
> -}
>
>
>

Powered by Google App Engine
This is Rietveld 408576698