Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1745)

Issue 441083002: Make all Blink API OWNERS be Source/OWNERS (Closed)

Created:
6 years, 4 months ago by eseidel
Modified:
6 years, 4 months ago
CC:
abarth-chromium, blink-reviews
Project:
blink
Visibility:
Public.

Description

Make all Blink API OWNERS be Source/OWNERS We had an explicit list of these folks for modules, but given that these individuals are charged with Blink's long-term stewardship, it makes sense that they should be able to review all changes across Blink's source. This also makes this list publicly documented which we had failed to do so in the past. R=abarth@chromium.org, dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179975

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
A + Source/OWNERS View 1 chunk +1 line, -6 lines 0 comments Download
M Source/modules/OWNERS View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
dglazkov
lgtm
6 years, 4 months ago (2014-08-05 21:32:50 UTC) #1
abarth-chromium
LGTM
6 years, 4 months ago (2014-08-05 21:33:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/441083002/1
6 years, 4 months ago (2014-08-05 21:35:41 UTC) #3
Peter Beverloo
On 2014/08/05 21:35:41, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 4 months ago (2014-08-05 23:41:11 UTC) #4
Peter Beverloo
On 2014/08/05 23:41:11, Peter Beverloo wrote: > On 2014/08/05 21:35:41, I haz the power (commit-bot) ...
6 years, 4 months ago (2014-08-05 23:42:14 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-06 02:47:38 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 03:23:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/19194)
6 years, 4 months ago (2014-08-06 03:23:53 UTC) #8
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 4 months ago (2014-08-11 17:13:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/441083002/1
6 years, 4 months ago (2014-08-11 17:13:21 UTC) #10
commit-bot: I haz the power
Change committed as 179975
6 years, 4 months ago (2014-08-11 17:39:44 UTC) #11
jamesr
I like this, but it's a little confusing now that the 'Blink API owners' documented ...
6 years, 4 months ago (2014-08-11 17:58:40 UTC) #12
eseidel
6 years, 4 months ago (2014-08-11 18:03:59 UTC) #13
Message was sent while issue was closed.
Agreed.  There is a doc here: http://www.chromium.org/blink/#TOC-API-Owners but
it's wrong. :/

Powered by Google App Engine
This is Rietveld 408576698