Cleanup of SSLHostStateDelegate and related code

chrome/browser/ssl/chrome_ssl_host_state_delegate_test.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 
 #include "base/command_line.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/test/simple_test_clock.h"
 #include "chrome/browser/browsing_data/browsing_data_helper.h"
 #include "chrome/browser/browsing_data/browsing_data_remover.h"
 #include "chrome/browser/browsing_data/browsing_data_remover_test_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ssl/chrome_ssl_host_state_delegate.h"

[willchan no longer on Chromium, 2014/08/20 22:17:22]

Goes first:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Names_....

The rule applies to both foo.cc and foo_test.cc:

"In dir/foo.cc or dir/foo_test.cc, whose main purpose is to implement or test
the stuff in dir2/foo2.h, order your includes as follows"

[jww, 2014/08/22 00:54:17]

Done.

 #include "chrome/browser/ssl/chrome_ssl_host_state_delegate_factory.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "content/public/browser/ssl_host_state_delegate.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/browser_test_utils.h"
 #include "net/base/test_data_directory.h"
 #include "net/test/cert_test_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
 const char kGoogleCertFile[] = "google.single.der";
 
 const char kWWWGoogleHost[] = "www.google.com";
 const char kGoogleHost[] = "google.com";
 const char kExampleHost[] = "example.com";
 
 const char* kForgetAtSessionEnd = "-1";

[willchan no longer on Chromium, 2014/08/20 22:17:22]

These 3 aren't constants. They're non-const pointers to a const char[]. You
should do the same as above, const char kFoo[] = ...; to turn them into real
constants.

[jww, 2014/08/22 00:54:17]

Done.

 const char* kForgetInstantly = "0";
 const char* kDeltaSecondsString = "86400";
 const uint64_t kDeltaOneDayInSeconds = UINT64_C(86400);
 
 scoped_refptr<net::X509Certificate> GetGoogleCert() {
   return net::ImportCertFromFile(net::GetTestCertsDirectory(), kGoogleCertFile);
 }
 
 }  // namespace
 
 class ChromeSSLHostStateDelegateTest : public InProcessBrowserTest {};
 
 // ChromeSSLHostStateDelegateTest tests basic unit test functionality of the
 // SSLHostStateDelegate class.  For example, tests that if a certificate is
 // accepted, then it is added to queryable, and if it is revoked, it is not
 // queryable. Even though it is effectively a unit test, in needs to be an
 // InProcessBrowserTest because the actual functionality is provided by

[willchan no longer on Chromium, 2014/08/20 22:17:22]

Not for readability, but would you be able to write a smaller test if you didn't
use Profile in ChromeSSLHostStateDelegate?

[jww, 2014/08/22 00:54:17]

Probably not because the implementation relies on an actual content settings
implementation, which is built per Profile.

 // ChromeSSLHostStateDelegate which is provided per-profile.
 //
 // QueryPolicy unit tests the expected behavior of calling QueryPolicy on the
 // SSLHostStateDelegate class after various SSL cert decisions have been made.
 IN_PROC_BROWSER_TEST_F(ChromeSSLHostStateDelegateTest, QueryPolicy) {
   scoped_refptr<net::X509Certificate> google_cert = GetGoogleCert();
   content::WebContents* tab =
       browser()->tab_strip_model()->GetActiveWebContents();
   Profile* profile = Profile::FromBrowserContext(tab->GetBrowserContext());
   content::SSLHostStateDelegate* state = profile->GetSSLHostStateDelegate();
@@ skipping 512 matching lines @@
   // worth of browsing history and verify that the exception has been deleted.
   state->AllowCert(
       kGoogleHost, google_cert.get(), net::CERT_STATUS_DATE_INVALID);
   RemoveAndWait(profile);
   EXPECT_EQ(net::CertPolicy::UNKNOWN,
             state->QueryPolicy(kGoogleHost,
                                google_cert.get(),
                                net::CERT_STATUS_DATE_INVALID,
                                &unused_value));
 }
+