Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 441033003: Merge 279078 "Video Capture: Allow 0 fps frame rates to be deser..." (Closed)

Created:
6 years, 4 months ago by vrk (LEFT CHROMIUM)
Modified:
6 years, 4 months ago
Reviewers:
mcasas
CC:
chromium-reviews, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Merge 279078 "Video Capture: Allow 0 fps frame rates to be deser..." > Video Capture: Allow 0 fps frame rates to be deserializable > > Some webcams, notably the Win XSplit broadcaster, > indicate 0 fps frame rate when they are not started/ > configured. This rate is not deserializable > (because is not IsValid()) [1]. This CL allows > supported formats with 0 fps to be received via > IPC. > > XSplit walkthrough before-after: > > Currently when XSplit lists 0 fps, the message > cannot be deserialized from the IPC and is > discarded; getUserMedia constraint resolution > @MediaStreamVideoCapturerSource never > progresses since is expecting that message. > > With this change, 0 fps will be used, and since > for unconfigured XSplit this is the only frame > rate, it's used (unless the user constrains it > via Mandatory constraint). When the 0 fps > selected format is passed to the > VideoCaptureDeviceWin to be used, this ignores > it (since is zero), and the capture happens > at whatever frame rate is native to the > source. And then we see an XSplit picture > indicating this fact. When streaming starts, > the picture is substituted with the feed. > > BUG=383949 > > [1] https://code.google.com/p/chromium/codesearch#chromium/src/media/video/capture/video_capture_types.cc&sq=package:chromium&type=cs&q=IsValid%20video%20&l=26 > > Review URL: https://codereview.chromium.org/332863002 TBR=mcasas@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287599

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M content/renderer/media/media_stream_video_source_unittest.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M media/video/capture/video_capture_types.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
vrk (LEFT CHROMIUM)
6 years, 4 months ago (2014-08-05 21:06:32 UTC) #1
vrk (LEFT CHROMIUM)
6 years, 4 months ago (2014-08-05 21:07:42 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r287599 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698