Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 441033002: cc: Clear tile priorities when tiling is reset. (Closed)

Created:
6 years, 4 months ago by vmpstr
Modified:
6 years, 4 months ago
Reviewers:
danakj, reveman
CC:
chromium-reviews, cc-bugs_chromium.org, sohanjg
Project:
chromium
Visibility:
Public.

Description

cc: Clear tile priorities when tiling is reset. This patch ensures that we clear the existing tile priorities when the tiling is reset. R=reveman Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287710

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M cc/resources/picture_layer_tiling.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M cc/resources/picture_layer_tiling.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/resources/picture_layer_tiling_unittest.cc View 1 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
vmpstr
PTAL.
6 years, 4 months ago (2014-08-05 20:22:06 UTC) #1
danakj
LGTM but kinda meh about this code duplication all over PLT to make this call.
6 years, 4 months ago (2014-08-05 20:31:06 UTC) #2
danakj
Should this have a test of some sort?
6 years, 4 months ago (2014-08-05 20:31:27 UTC) #3
vmpstr
On 2014/08/05 20:31:27, danakj wrote: > Should this have a test of some sort? My ...
6 years, 4 months ago (2014-08-05 21:11:45 UTC) #4
danakj
On Tue, Aug 5, 2014 at 5:11 PM, <vmpstr@chromium.org> wrote: > On 2014/08/05 20:31:27, danakj ...
6 years, 4 months ago (2014-08-05 21:14:00 UTC) #5
vmpstr
On 2014/08/05 21:14:00, danakj wrote: > On Tue, Aug 5, 2014 at 5:11 PM, <mailto:vmpstr@chromium.org> ...
6 years, 4 months ago (2014-08-05 23:28:58 UTC) #6
vmpstr
The CQ bit was checked by vmpstr@chromium.org
6 years, 4 months ago (2014-08-05 23:29:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/441033002/20001
6 years, 4 months ago (2014-08-05 23:30:09 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 06:36:50 UTC) #9
Message was sent while issue was closed.
Change committed as 287710

Powered by Google App Engine
This is Rietveld 408576698