Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 441027: Merge 32311 - Hold histograms in static variables instead of allocating heap.... (Closed)

Created:
11 years ago by ukai
Modified:
9 years, 7 months ago
Reviewers:
ukai
CC:
chromium-reviews_googlegroups.com, darin (slow to review), ben+cc_chromium.org
Visibility:
Public.

Description

Merge 32311 - Hold histograms in static variables instead of allocating heap. If instance variables holding pointers to Histograms, it would cause crash bug when the instance is torn down and the metrics services use and recording of their contents. The current "standard" patten for using Histograms includes making sure that the Histogram instances are not destroyed prematurely, held in static variables. BUG=28096 TEST=none Review URL: http://codereview.chromium.org/404022 TBR=ukai@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33185

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -112 lines) Patch
M chrome/browser/net/websocket_experiment/websocket_experiment_runner.h View 2 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/net/websocket_experiment/websocket_experiment_runner.cc View 5 chunks +94 lines, -98 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
ukai
11 years ago (2009-11-26 06:42:28 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698