Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4344)

Unified Diff: build/android/pylib/gtest/test_package.py

Issue 441023002: [Android] Fix type-parameterized gtest parsing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/pylib/gtest/test_package_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/gtest/test_package.py
diff --git a/build/android/pylib/gtest/test_package.py b/build/android/pylib/gtest/test_package.py
index fcc53b7b092d401e74cf7b02958fa072fa17cf23..225f774acdb2ccbfc4fe6a778128f2077bd0c031 100644
--- a/build/android/pylib/gtest/test_package.py
+++ b/build/android/pylib/gtest/test_package.py
@@ -88,11 +88,10 @@ class TestPackage(object):
for test in raw_list:
if not test:
continue
- if test[0] != ' ' and not test.endswith('.'):
- # Ignore any lines with unexpected format.
- continue
- if test[0] != ' ' and test.endswith('.'):
- current = test
+ if test[0] != ' ':
+ test_case = test.split(None, 1)[0]
craigdh 2014/08/05 20:59:31 how is this different from test.split()[0]?
jbudorick 2014/08/05 21:04:10 As before, functionally the same, but it only does
craigdh 2014/08/05 21:23:33 Ah, I never saw your response to the other one. I
+ if test_case.endswith('.'):
+ current = test_case
continue
craigdh 2014/08/05 20:59:31 use an else instead
jbudorick 2014/08/05 21:04:10 Done.
if 'YOU HAVE' in test:
break
« no previous file with comments | « no previous file | build/android/pylib/gtest/test_package_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698