Issue 441022: Changed shared worker code so incognito windows do not have access to non-incognito shared workers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 441022: Changed shared worker code so incognito windows do not have access to non-incognito shared workers. (Closed)

Created:
11 years ago by Andrew T Wilson (Slow)

Modified:
9 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Changed shared worker code so incognito windows do not have access to non-incognito shared workers. BUG=27883 TEST=added new uitest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33164

Patch Set 1 #

Patch Set 2 : Updated DEPS file to reflect new dependency in worker UI tests. #

Patch Set 3 : Removed superfluous valgrind change. #

Total comments: 2

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+137 lines, -29 lines)			Patch
M	chrome/browser/renderer_host/resource_message_filter.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/worker_host/worker_process_host.h	View	4 chunks	+5 lines, -1 line	1 comment	Download
M	chrome/browser/worker_host/worker_process_host.cc	View	4 chunks	+18 lines, -7 lines	0 comments	Download
M	chrome/browser/worker_host/worker_service.h	View	4 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/worker_host/worker_service.cc	View	12 chunks	+22 lines, -14 lines	0 comments	Download
A	chrome/test/data/workers/incognito_worker.html	View	1 chunk	+34 lines, -0 lines	0 comments	Download
A	chrome/test/data/workers/incognito_worker.js	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/worker/DEPS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/worker/worker_uitest.cc	View	4 chunks	+41 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jam

11 years ago (2009-11-25 23:30:46 UTC) #2

lgtm

http://codereview.chromium.org/441022/diff/4001/5003
File chrome/browser/worker_host/worker_process_host.h (right):

http://codereview.chromium.org/441022/diff/4001/5003#newcode75
chrome/browser/worker_host/worker_process_host.h:75: bool is_off_the_record()
const { return off_the_record_; }
nit: I should have mentioned this last time, but simple getters don't have a
"is_" infront, so just off_the_record() or shared() or closed() are good enough
(to match all the other getters below)

http://codereview.chromium.org/441022/diff/4001/5009
File chrome/worker/worker_uitest.cc (right):

http://codereview.chromium.org/441022/diff/4001/5009#newcode94
chrome/worker/worker_uitest.cc:94: // http://crbug.com/27883
nit: no need to mention the bug number, as it'll be obvious to the reader, and
if someone really wants to know which bug this referenced, they can go through
the svn commit log.

Expand Messages | Collapse Messages