Issue 441013003: Move the logic of getting root window to StartObserving()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 441013003: Move the logic of getting root window to StartObserving() (Closed)

Created:
6 years, 4 months ago by Jun Mukai

Modified:
6 years, 4 months ago

Reviewers:
stevenjb

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Move the logic of getting root window to StartObserving() Crashes are reported around getting root window in UpdateShelf(), however the new AshPopupAlignmentDelegate is mostly same as old WorkAreaObserver. One difference is the location of getting root window. This could fix the problem. If this doesn't fix the problem, then the problem happens outside of this file. BUG=400492 R=stevenjb@chromium.org TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287859

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	ash/system/web_notification/ash_popup_alignment_delegate.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/441013003/1

6 years, 4 months ago (2014-08-06 18:07:55 UTC) #4

Message was sent while issue was closed.

Change committed as 287859

Expand Messages | Collapse Messages