components/metrics/metrics_service.cc - Issue 441013002: Eliminate MetricsProvider::RecordCurrentState()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/metrics_service.cc

Issue 441013002: Eliminate MetricsProvider::RecordCurrentState() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: RecordCurrentState is called before reading from prefs and delayed calls are canceled. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/metrics/metrics_service.cc

diff --git a/components/metrics/metrics_service.cc b/components/metrics/metrics_service.cc

index 925421fea799a8078234565b91068f9c81b28937..dd6e054012acf3df5f5bfcea549f28b6d7686fcb 100644

--- a/components/metrics/metrics_service.cc

+++ b/components/metrics/metrics_service.cc

@@ -1208,7 +1208,4 @@ void MetricsService::RecordBooleanPrefValue(const char* path, bool value) {

void MetricsService::RecordCurrentState(PrefService* pref) {

pref->SetInt64(metrics::prefs::kStabilityLastTimestampSec,

Time::Now().ToTimeT());

- for (size_t i = 0; i < metrics_providers_.size(); ++i)

- metrics_providers_[i]->RecordCurrentState();

}