Eliminate MetricsProvider::RecordCurrentState()

chrome/browser/metrics/plugin_metrics_provider.cc

Index: chrome/browser/metrics/plugin_metrics_provider.cc
diff --git a/chrome/browser/metrics/plugin_metrics_provider.cc b/chrome/browser/metrics/plugin_metrics_provider.cc
index f7f5c1b509afea41e2a867dce718899a38b934de..c47f528d079da915eb5f78d669e9f8e9378c0941 100644
--- a/chrome/browser/metrics/plugin_metrics_provider.cc
+++ b/chrome/browser/metrics/plugin_metrics_provider.cc
@@ -11,6 +11,7 @@
 #include "base/prefs/scoped_user_pref_update.h"
 #include "base/stl_util.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/time/time.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/plugins/plugin_prefs.h"
 #include "chrome/browser/profiles/profile_manager.h"
@@ -21,6 +22,9 @@
 #include "content/public/common/process_type.h"
 #include "content/public/common/webplugininfo.h"
 
+// Delay for RecordCurrentState execution 10 minutes in seconds.
+const int kRecordStateDelaySec = 10 * 60;

[Alexei Svitkine (slow), 2014/08/05 20:13:11]

I think we can make the delay much shorter - e.g. 15s.

Also, move it to the anon namespace just below.

[gayane -on leave until 09-2017, 2014/08/05 21:24:55]

Done.

+
 namespace {
 
 // Returns the plugin preferences corresponding for this user, if available.
@@ -299,6 +303,7 @@ void PluginMetricsProvider::LogPluginLoadingError(
     DCHECK(IsPluginProcess(stats.process_type));
   }
   stats.loading_errors++;
+  DelayedRecordCurrentState(kRecordStateDelaySec);
 }
 
 void PluginMetricsProvider::SetPluginsForTesting(
@@ -339,14 +344,30 @@ PluginMetricsProvider::GetChildProcessStats(
 void PluginMetricsProvider::BrowserChildProcessHostConnected(
     const content::ChildProcessData& data) {
   GetChildProcessStats(data).process_launches++;
+  DelayedRecordCurrentState(kRecordStateDelaySec);
 }
 
 void PluginMetricsProvider::BrowserChildProcessCrashed(
     const content::ChildProcessData& data) {
   GetChildProcessStats(data).process_crashes++;
+  DelayedRecordCurrentState(kRecordStateDelaySec);
 }
 
 void PluginMetricsProvider::BrowserChildProcessInstanceCreated(
     const content::ChildProcessData& data) {
   GetChildProcessStats(data).instances++;
+  DelayedRecordCurrentState(kRecordStateDelaySec);
+}
+
+bool PluginMetricsProvider::DelayedRecordCurrentState(int delay_sec) {
+  if (!weak_ptr_factory_.HasWeakPtrs()) {

[Alexei Svitkine (slow), 2014/08/05 20:13:11]

Nit: Chromium style prefers early returns rather than nesting - so reverse the
cond and do an early return here.

[gayane -on leave until 09-2017, 2014/08/05 21:24:55]

Done.

+    base::MessageLoopProxy::current()->PostDelayedTask(
+        FROM_HERE,
+        base::Bind(&PluginMetricsProvider::RecordCurrentState,
+                  weak_ptr_factory_.GetWeakPtr()),
+                  base::TimeDelta::FromSeconds(delay_sec));
+    return true;
+  }
+
+  return false;
 }