Eliminate MetricsProvider::RecordCurrentState()

chrome/browser/metrics/plugin_metrics_provider.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_METRICS_PLUGIN_METRICS_PROVIDER_H_
 #define CHROME_BROWSER_METRICS_PLUGIN_METRICS_PROVIDER_H_
 
 #include <map>
 #include <vector>
 
@@ skipping 24 matching lines @@
 
   // Fetches plugin information data asynchronously and calls |done_callback|
   // when done.
   void GetPluginInformation(const base::Closure& done_callback);
 
   // metrics::MetricsDataProvider:
   virtual void ProvideSystemProfileMetrics(
       metrics::SystemProfileProto* system_profile_proto) OVERRIDE;
   virtual void ProvideStabilityMetrics(
       metrics::SystemProfileProto* system_profile_proto) OVERRIDE;
-  virtual void RecordCurrentState() OVERRIDE;
+  void RecordCurrentState();

[Alexei Svitkine (slow), 2014/08/06 15:10:01]

Now that this is no longer an implementation of the interface, please add a
comment for the method and move it to the private section.

[gayane -on leave until 09-2017, 2014/08/06 19:38:27]

Done.

 
   // Notifies the provider about an error loading the plugin at |plugin_path|.
   void LogPluginLoadingError(const base::FilePath& plugin_path);
 
   // Sets this provider's list of plugins, exposed for testing.
   void SetPluginsForTesting(const std::vector<content::WebPluginInfo>& plugins);
 
+  // Posts a delayed task for RecordCurrentState. Returns true if new task is
+  // posted and false if there was one already waiting for execution.
+  // The param delay_sec is for unit tests.
+  bool RecordCurrentStateWithDelay(int delay_ms);

[Alexei Svitkine (slow), 2014/08/06 15:10:01]

The new methods you're adding shouldn't be public. Instead, make them private
and you can set the new test to be a friend. (See variations_service.h for an
example how to do that with the FRIEND_TEST macros).

[gayane -on leave until 09-2017, 2014/08/06 19:38:27]

Done.

+
+  // If a delayed RecordCurrnetState task exists than cancels it, calls

[Alexei Svitkine (slow), 2014/08/06 15:10:01]

nit: than -> then

[gayane -on leave until 09-2017, 2014/08/06 19:38:27]

Done.

+  // RecordCurrentState immediately and returns true. Otherwise returns false.
+  bool RecordCurrentStateIfPending();
+
   // Returns true if process of type |type| should be counted as a plugin
   // process, and false otherwise.
   static bool IsPluginProcess(int process_type);
 
   // Registers local state prefs used by this class.
   static void RegisterPrefs(PrefRegistrySimple* registry);
 
  private:
   struct ChildProcessStats;
 
@@ skipping 20 matching lines @@
 
   // Buffer of child process notifications for quick access.
   std::map<base::string16, ChildProcessStats> child_process_stats_buffer_;
 
   base::WeakPtrFactory<PluginMetricsProvider> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(PluginMetricsProvider);
 };
 
 #endif  // CHROME_BROWSER_METRICS_PLUGIN_METRICS_PROVIDER_H_