components/metrics/metrics_provider.h - Issue 441013002: Eliminate MetricsProvider::RecordCurrentState()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/metrics/metrics_provider.h

Issue 441013002: Eliminate MetricsProvider::RecordCurrentState() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: RecordCurrentState is called before reading from prefs and delayed calls are canceled. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/metrics/plugin_metrics_provider_unittest.cc ('K') | « chrome/browser/metrics/plugin_metrics_provider_unittest.cc ('k') | components/metrics/metrics_service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_METRICS_METRICS_PROVIDER_H_	5 #ifndef COMPONENTS_METRICS_METRICS_PROVIDER_H_

6 #define COMPONENTS_METRICS_METRICS_PROVIDER_H_	6 #define COMPONENTS_METRICS_METRICS_PROVIDER_H_

7	7

8 #include "base/basictypes.h"	8 #include "base/basictypes.h"

9	9

10 namespace metrics {	10 namespace metrics {

(...skipping 26 matching lines...) Expand all Loading...
37 // directly into \|stability_proto\| fields or by logging stability histograms	37 // directly into \|stability_proto\| fields or by logging stability histograms

38 // via the UMA_STABILITY_HISTOGRAM_ENUMERATION() macro.	38 // via the UMA_STABILITY_HISTOGRAM_ENUMERATION() macro.

39 virtual void ProvideStabilityMetrics(	39 virtual void ProvideStabilityMetrics(

40 SystemProfileProto* system_profile_proto) {}	40 SystemProfileProto* system_profile_proto) {}

41	41

42 // Provides general metrics that are neither system profile nor stability	42 // Provides general metrics that are neither system profile nor stability

43 // metrics.	43 // metrics.

44 virtual void ProvideGeneralMetrics(	44 virtual void ProvideGeneralMetrics(

45 ChromeUserMetricsExtension* uma_proto) {}	45 ChromeUserMetricsExtension* uma_proto) {}

46	46

47 // TODO(asvitkine): Remove this method. http://crbug.com/379148

48 virtual void RecordCurrentState() {}

49

50 private:	47 private:

51 DISALLOW_COPY_AND_ASSIGN(MetricsProvider);	48 DISALLOW_COPY_AND_ASSIGN(MetricsProvider);

52 };	49 };

53	50

54 } // namespace metrics	51 } // namespace metrics

55	52

56 #endif // COMPONENTS_METRICS_METRICS_PROVIDER_H_	53 #endif // COMPONENTS_METRICS_METRICS_PROVIDER_H_

OLD	NEW