Eliminate MetricsProvider::RecordCurrentState()

chrome/browser/metrics/plugin_metrics_provider_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/plugin_metrics_provider.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/scoped_user_pref_update.h"
 #include "base/prefs/testing_pref_service.h"
+#include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/common/pref_names.h"
 #include "components/metrics/proto/system_profile.pb.h"
 #include "content/public/common/process_type.h"
 #include "content/public/common/webplugininfo.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
@@ skipping 70 matching lines @@
   ASSERT_EQ(1, stability.plugin_stability_size());
   EXPECT_EQ("p2", stability.plugin_stability(0).plugin().name());
   EXPECT_EQ("p2.plugin", stability.plugin_stability(0).plugin().filename());
   EXPECT_EQ("2.0", stability.plugin_stability(0).plugin().version());
   EXPECT_FALSE(stability.plugin_stability(0).plugin().is_pepper());
   EXPECT_EQ(1, stability.plugin_stability(0).launch_count());
   EXPECT_EQ(2, stability.plugin_stability(0).crash_count());
   EXPECT_EQ(3, stability.plugin_stability(0).instance_count());
   EXPECT_EQ(4, stability.plugin_stability(0).loading_error_count());
 }
+
+TEST(PluginMetricsProviderTest, CheckDelayedTask) {
+  content::TestBrowserThreadBundle thread_bundle;
+
+  TestingPrefServiceSimple prefs;
+  PluginMetricsProvider::RegisterPrefs(prefs.registry());
+  PluginMetricsProvider provider(&prefs);
+
+  int delay_sec = 1;
+  EXPECT_EQ(true, provider.DelayedRecordCurrentState(delay_sec));

[Alexei Svitkine (slow), 2014/08/05 20:13:12]

Nit: use EXPECT_TRUE and EXPECT_FALSE

[gayane -on leave until 09-2017, 2014/08/05 21:24:56]

Done.

+  EXPECT_EQ(false, provider.DelayedRecordCurrentState(delay_sec));
+
+  sleep(delay_sec);

[Alexei Svitkine (slow), 2014/08/05 20:13:12]

Use base::PlatformThread::Sleep() instead.

[gayane -on leave until 09-2017, 2014/08/05 21:24:55]

Done.

+  base::RunLoop().RunUntilIdle();
+
+  EXPECT_EQ(true, provider.DelayedRecordCurrentState(delay_sec));
+}