Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 440963002: Remove WheelEvent.webkitDirectionInvertedFromDevice (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
Reviewers:
abarth-chromium
CC:
arv+blink, blink-reviews, Inactive
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -51 lines) Patch
D LayoutTests/fast/events/wheelevent-direction-inverted-from-device.html View 1 chunk +0 lines, -32 lines 0 comments Download
D LayoutTests/fast/events/wheelevent-direction-inverted-from-device-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/core/events/WheelEvent.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/events/WheelEvent.idl View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
philipj_slow
PTAL
6 years, 4 months ago (2014-08-05 18:48:37 UTC) #1
abarth-chromium
LGTM
6 years, 4 months ago (2014-08-05 20:50:15 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-08-05 20:57:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/440963002/1
6 years, 4 months ago (2014-08-05 20:59:08 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-06 02:57:10 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 03:33:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/19837)
6 years, 4 months ago (2014-08-06 03:33:47 UTC) #7
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 4 months ago (2014-08-06 04:13:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/440963002/1
6 years, 4 months ago (2014-08-06 04:13:49 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-06 04:22:55 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 04:31:19 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/19892)
6 years, 4 months ago (2014-08-06 04:31:20 UTC) #12
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-08-06 06:02:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/440963002/1
6 years, 4 months ago (2014-08-06 06:03:18 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 06:58:08 UTC) #15
Message was sent while issue was closed. 
Change committed as 179565

Powered by Google App Engine
This is Rietveld 408576698