Issue 440913002: DevTools: Async call stacks for FileSystem API part 2.

Issue 440913002: DevTools: Async call stacks for FileSystem API part 2. (Closed)

Created:
6 years, 4 months ago by aandrey

Modified:
6 years, 4 months ago

Reviewers:
kinuko, nhiroki, pfeldman, yurys

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, tzik, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, nhiroki, devtools-reviews_chromium.org, arv+blink, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kinuko+fileapi, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Async call stacks for FileSystem API part 2. Instrumenting FileReader & FileWriter. BUG=272416, 390863 R=pfeldman, yurys, kinuko@chromium.org, nhiroki@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179624

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -6 lines)			Patch
M	LayoutTests/http/tests/inspector/filesystem/async-callstack-filesystem-expected.txt	View	1 chunk	+28 lines, -0 lines	0 comments	Download
M	Source/core/fileapi/FileReader.h	View	2 chunks	+1 line, -1 line	1 comment	Download
M	Source/core/fileapi/FileReader.cpp	View	6 chunks	+9 lines, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorDebuggerAgent.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/inspector/InspectorDebuggerAgent.cpp	View	1 chunk	+6 lines, -4 lines	0 comments	Download
M	Source/core/inspector/InspectorInstrumentation.idl	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/modules/filesystem/FileWriter.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/modules/filesystem/FileWriter.cpp	View	4 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

aandrey

https://codereview.chromium.org/440913002/diff/1/Source/core/fileapi/FileReader.h File Source/core/fileapi/FileReader.h (left): https://codereview.chromium.org/440913002/diff/1/Source/core/fileapi/FileReader.h#oldcode109 Source/core/fileapi/FileReader.h:109: void fireErrorEvent(int httpStatusCode); dead code

6 years, 4 months ago (2014-08-05 16:03:59 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/440913002/1

6 years, 4 months ago (2014-08-06 12:38:39 UTC) #8

Message was sent while issue was closed.

Change committed as 179624

Expand Messages | Collapse Messages