Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4820)

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_icon_view.h

Issue 440903002: Password "key" icon in the omnibox should be focusable. If the bubble is open then it automatically… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/manage_passwords_icon_view.h
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_icon_view.h b/chrome/browser/ui/views/passwords/manage_passwords_icon_view.h
index 77cbd83f6f6e9bc2a1e67d2cdff869a5a637b0f9..77512bcb75b872e51e2c7065ea305b4ce890ff13 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_icon_view.h
+++ b/chrome/browser/ui/views/passwords/manage_passwords_icon_view.h
@@ -25,6 +25,10 @@ class ManagePasswordsIconView : public ManagePasswordsIcon,
virtual bool IsBubbleShowing() const OVERRIDE;
virtual void OnExecuting(BubbleIconView::ExecuteSource source) OVERRIDE;
virtual bool OnMousePressed(const ui::MouseEvent& event) OVERRIDE;
+ virtual bool OnKeyPressed(const ui::KeyEvent& event) OVERRIDE;
+
+ // views::View:
+ virtual void AboutToRequestFocusFromTabTraversal(bool reverse) OVERRIDE;
#if defined(UNIT_TEST)
int icon_id() const { return icon_id_; }

Powered by Google App Engine
This is Rietveld 408576698