chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h - Issue 440903002: Password "key" icon in the omnibox should be focusable. If the bubble is open then it automatically…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h

Issue 440903002: Password "key" icon in the omnibox should be focusable. If the bubble is open then it automatically… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc » ('j') | chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h

diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h

index 6acad537c30cade0c50ac003af1081b893ed028d..17c93dd73a8e12139af326e2332bf51fc5a096a5 100644

--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h

+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h

@@ -159,6 +159,9 @@ class ManagePasswordsBubbleView : public ManagePasswordsBubble,

// Closes any existing bubble.

static void CloseBubble();

+ // Makes the bubble foreground window.

Mike West 2014/08/05 16:41:55 Nit: "the foreground window"

vasilii 2014/08/06 09:14:01 Done.

+ static void ActivateBubble();

// Whether the bubble is currently showing.

static bool IsShowing();