Password "key" icon in the omnibox should be focusable. If the bubble is open then it automatically…

chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/passwords/manage_passwords_icon_view.h"
 
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/command_updater.h"
 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
 #include "chrome/browser/ui/view_ids.h"
 #include "chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h"
 #include "components/password_manager/core/common/password_manager_ui.h"
 #include "grit/generated_resources.h"
 #include "grit/theme_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 
 ManagePasswordsIconView::ManagePasswordsIconView(CommandUpdater* updater)
     : BubbleIconView(updater, IDC_MANAGE_PASSWORDS_FOR_PAGE),
       icon_id_(0),
       tooltip_text_id_(0) {
   set_id(VIEW_ID_MANAGE_PASSWORDS_ICON_BUTTON);
-  SetAccessibilityFocusable(true);
+  SetFocusable(true);

[Mike West, 2014/08/05 16:42:24]

What's the difference?

[vasilii, 2014/08/06 09:14:01]

AccessibilityFocusable means focusable for accessibility user's only. Now it's
just focusable for everybody.

   UpdateVisibleUI();
 }
 
 ManagePasswordsIconView::~ManagePasswordsIconView() {}
 
 void ManagePasswordsIconView::UpdateVisibleUI() {
   // If the icon is inactive: clear out it's image and tooltip, hide the icon,
   // close any active bubble, and exit early.
   if (state() == password_manager::ui::INACTIVE_STATE) {
     icon_id_ = 0;
@@ skipping 34 matching lines @@
 void ManagePasswordsIconView::OnExecuting(
     BubbleIconView::ExecuteSource source) {
 }
 
 bool ManagePasswordsIconView::OnMousePressed(const ui::MouseEvent& event) {
   bool result = BubbleIconView::OnMousePressed(event);
   if (IsBubbleShowing())
     ManagePasswordsBubbleView::CloseBubble();
   return result;
 }
+
+bool ManagePasswordsIconView::OnKeyPressed(const ui::KeyEvent& event) {
+  // Space is always ignored because otherwise the bubble appears with the
+  // default button down. Releasing the space is equivalent to clicking this
+  // button.
+  if (event.key_code() == ui::VKEY_SPACE)
+    return true;
+  if (event.key_code() == ui::VKEY_RETURN && active()) {
+    // If the icon is active, it should transfer its focus to the bubble.
+    // If it still somehow got this key event, the bubble shouldn't be reopened.
+    return true;
+  }
+  return BubbleIconView::OnKeyPressed(event);
+}
+
+void ManagePasswordsIconView::AboutToRequestFocusFromTabTraversal(
+    bool reverse) {
+  if (active())

[Mike West, 2014/08/05 16:41:55]

You need to check reverse here. Otherwise shift-tab is broken.

[vasilii, 2014/08/06 09:14:01]

Shift-Tab is fine. The focus goes to the bubble to the default button.

[Mike West, 2014/08/06 09:17:46]

If I shift-tab out of the bubble, what happens? Perhaps I've misunderstood the
tab order, but if it's something like:

Omnibox Button -> Bubble

Then tabbing out of the bubble would land on the omnibox icon, which would put
me back in the bubble, right?

+    ManagePasswordsBubbleView::ActivateBubble();
+}