Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1611)

Unified Diff: chrome/browser/browser_process_impl.cc

Issue 440893002: RundownTaskCounter needs to use a non-nestable task to block on the completion of already scheduled… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_process_impl.cc
diff --git a/chrome/browser/browser_process_impl.cc b/chrome/browser/browser_process_impl.cc
index 01cac71b8f0858ec7963941690669f68e81170d2..34b25146884cc31b30c0e86f7938eb9c84a95f2f 100644
--- a/chrome/browser/browser_process_impl.cc
+++ b/chrome/browser/browser_process_impl.cc
@@ -426,7 +426,9 @@ void RundownTaskCounter::Post(base::SequencedTaskRunner* task_runner) {
base::AtomicRefCountInc(&count_);
- task_runner->PostTask(FROM_HERE,
+ // The task must be non-nestable to guarantee that it runs after all tasks
+ // currently scheduled on |task_runner| have completed.
+ task_runner->PostNonNestableTask(FROM_HERE,
base::Bind(&RundownTaskCounter::Decrement, this));
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698