Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 440833005: MacViews: Add stubs for toolkit-views BrowserActionTestUtil functions for Mac (Closed)

Created:
6 years, 4 months ago by tapted
Modified:
6 years, 4 months ago
Reviewers:
groby-ooo-7-16, Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

MacViews: Add stubs for toolkit-views BrowserActionTestUtil functions for Mac This is part of allowing interactive_ui_tests to compile on MacViews for initial coverage on the bots (while still using Cocoa UI). That is, the goal here is to get interactive_ui_tests to link so that other tests can run (initially). BUG=399191 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287943

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chrome/browser/extensions/browser_action_test_util.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tapted
Hi Devlin, could you please take a look? (this is split of from the "big ...
6 years, 4 months ago (2014-08-05 08:30:01 UTC) #1
Devlin
extensions lgtm
6 years, 4 months ago (2014-08-05 15:47:40 UTC) #2
tapted
+groby for c/b/ui/cocoa/ OWNERS although it's such a dull CL :). Maybe we should have ...
6 years, 4 months ago (2014-08-06 03:50:45 UTC) #3
groby-ooo-7-16
LGTM - want to add yourself as an owner to extensions? :)
6 years, 4 months ago (2014-08-06 18:40:07 UTC) #4
tapted
On 2014/08/06 18:40:07, groby wrote: > LGTM - want to add yourself as an owner ...
6 years, 4 months ago (2014-08-06 23:01:10 UTC) #5
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 4 months ago (2014-08-06 23:01:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/440833005/1
6 years, 4 months ago (2014-08-06 23:02:37 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 02:49:30 UTC) #8
Message was sent while issue was closed.
Change committed as 287943

Powered by Google App Engine
This is Rietveld 408576698