policy: Remove UserCloudPolicyManagerFactory's dependency on Profile.

policy: Remove UserCloudPolicyManagerFactory's dependency on Profile.

Changes all relevant occurrences of Profile by BrowserContext.

BUG=271392
(dubroy@ for policy_ui, tedchoc@ for signin_manager_android.cc, joi@ for DEPS)

R=erg@chromium.org, joaodasilva@chromium.org
TBR=dubroy@chromium.org, joi@chromium.org, tedchoc@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233267

[pneubeck (no reviews), 2013-10-25 15:18:52]

early preview

[pneubeck (no reviews), 2013-10-30 12:10:11]

should be ok for review now.

[Joao da Silva, 2013-11-04 10:02:54]

lgtm but I think you can drop the changes to signin_manager*

https://codereview.chromium.org/44083005/diff/240001/chrome/browser/policy/cl...
File chrome/browser/policy/cloud/user_cloud_policy_store.cc (right):

https://codereview.chromium.org/44083005/diff/240001/chrome/browser/policy/cl...
chrome/browser/policy/cloud/user_cloud_policy_store.cc:220:
SigninManagerFactory::GetForBrowserContextIfExists(context_);
This renaming (and the changes to signin_manager_*) shouldn't be needed after
https://codereview.chromium.org/49783006, right?

[Joao da Silva, 2013-11-04 12:57:45]

lgtm

https://codereview.chromium.org/44083005/diff/1130001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/policy_ui.cc (right):

https://codereview.chromium.org/44083005/diff/1130001/chrome/browser/ui/webui...
chrome/browser/ui/webui/policy_ui.cc:493:
web_ui()->GetWebContents()->GetBrowserContext());
You could keep the Profile::FromWebUI arg here

[pneubeck (no reviews), 2013-11-04 12:58:11]

Reverted the changes to SigninManagerFactory.

[pneubeck (no reviews), 2013-11-04 13:01:42]

https://codereview.chromium.org/44083005/diff/1130001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/policy_ui.cc (right):

https://codereview.chromium.org/44083005/diff/1130001/chrome/browser/ui/webui...
chrome/browser/ui/webui/policy_ui.cc:493:
web_ui()->GetWebContents()->GetBrowserContext());
On 2013/11/04 12:57:45, Joao da Silva wrote:
> You could keep the Profile::FromWebUI arg here

Yes I could, but it's an unnecessary indirection through Profile and dependency
on Profile, IMO.

For the record, this is the implementation of Profile::FromWebUI:
static_cast<Profile*>(web_ui->GetWebContents()->GetBrowserContext());

[pneubeck (no reviews), 2013-11-04 13:02:24]

@Elliot, please take a look at this one as well.
Thanks.

[Elliot Glaysher, 2013-11-05 01:28:00]

lgtm

[commit-bot: I haz the power, 2013-11-05 21:48:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pneubeck@chromium.org/44083005/1420001

[commit-bot: I haz the power, 2013-11-05 22:52:10]

Retried try job too often on linux_rel for step(s) base_unittests,
browser_tests, interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-11-06 09:25:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pneubeck@chromium.org/44083005/1800001

[commit-bot: I haz the power, 2013-11-06 12:29:32]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[pneubeck (no reviews), 2013-11-06 14:03:11]

Committed patchset #8 manually as r233267 (presubmit successful).