Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 440813003: mac: Actually include libc++ headers in clang package. (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
6 years, 4 months ago
Reviewers:
hans
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

mac: Actually include libc++ headers in clang package. Follow-up to r270095 where I tried to do this already, but wasn't quite successful. (It worked on my box, but nowhere else.) BUG=400088 R=hans@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287585

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tools/clang/scripts/package.sh View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
:-/
6 years, 4 months ago (2014-08-05 18:14:14 UTC) #1
hans
lgtm Why did it work on your machine if you weren't tar'ing up the include/ ...
6 years, 4 months ago (2014-08-05 18:19:23 UTC) #2
Nico
On 2014/08/05 18:19:23, hans wrote: > lgtm > > Why did it work on your ...
6 years, 4 months ago (2014-08-05 18:21:32 UTC) #3
Nico
6 years, 4 months ago (2014-08-05 20:42:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 287585 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698