chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc - Issue 440813002: Expose gallery watching functionality to the public mediaGalleries API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc

Issue 440813002: Expose gallery watching functionality to the public mediaGalleries API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to Tommy's comments. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/media_galleries/media_galleries_watch_apitest.cc ('K') | « chrome/browser/extensions/api/media_galleries/media_galleries_watch_apitest.cc ('k') | chrome/chrome_tests.gypi » ('j') | chrome/test/data/extensions/api_test/media_galleries/gallerywatch/test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc

diff --git a/chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc b/chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc

index db2759e9db8775c125f87029e94930c4dc9ec8ac..3159d3bdee7ad152d5b21ee40909af6e06e17677 100644

--- a/chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc

+++ b/chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc

@@ -49,9 +49,8 @@ void HandleProfileShutdownOnFileThread(void* profile_id) {

GalleryWatchManager::OnProfileShutdown(profile_id);

}

-// Gets the |gallery_file_path| and |gallery_pref_id| of the gallery specified

-// by the |gallery_id|. Returns true and set |gallery_file_path| and

-// |gallery_pref_id| if the |gallery_id| is valid and returns false otherwise.

+// Returns true and sets |gallery_file_path| and |gallery_pref_id| if the

+// |gallery_id| is valid and returns false otherwise.

bool GetGalleryFilePathAndId(const std::string& gallery_id,

Profile* profile,

const Extension* extension,