extensions/browser/extension_function.cc - Issue 440813002: Expose gallery watching functionality to the public mediaGalleries API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_function.cc

Issue 440813002: Expose gallery watching functionality to the public mediaGalleries API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup the code and prepare for review. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/api_test/media_galleries/gallerywatch/test.js ('K') | « chrome/test/data/extensions/api_test/media_galleries/gallerywatch/test.js ('k') | extensions/browser/extension_function_histogram_value.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/extension_function.cc

diff --git a/extensions/browser/extension_function.cc b/extensions/browser/extension_function.cc

index 773f027bac20c4e618c1b17cd5bfc24ab791f035..09cabbd31eaa224e7d686d104afa0ac6bf39e51e 100644

--- a/extensions/browser/extension_function.cc

+++ b/extensions/browser/extension_function.cc

@@ -321,7 +321,6 @@ void ExtensionFunction::SendResponseImpl(bool success) {

ResponseType type = success ? SUCCEEDED : FAILED;

if (bad_message_) {

type = BAD_MESSAGE;

- LOG(ERROR) << "Bad extension message " << name_;

tommycli 2014/08/19 16:36:03 Interesting... why?

Oren Blasberg 2014/08/20 22:59:37 Ugh. My bad, this was removed in error (i was debu

}

// If results were never set, we send an empty argument list.