Don't crash when splices are in the past due to bad media.

Don't crash when splices are in the past due to bad media.

Bad media may result in splice frames way in the past.  We need
to avoid crashing in this case.  See the bug for more details.

BUG=400442
TEST=new media test.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288284

[wolenetz, 2014-08-05 01:00:28]

Quick question: (I'll fully review in the morning.)

https://codereview.chromium.org/440803002/diff/1/media/base/audio_splicer.cc
File media/base/audio_splicer.cc (left):

https://codereview.chromium.org/440803002/diff/1/media/base/audio_splicer.cc#...
media/base/audio_splicer.cc:305: if (pre_splice_sanitizer_->GetFrameCount() <=
I'm trying to grok which part of this condition previously led to the CHECK, but
doesn't in your patch set. What were the previous values of r
pre_splice_sanitizer_->GetFrameCount() and
output_ts_helper.GetFramesToTarget(splice_timestamp_) that led to the CHECK?

[DaleCurtis, 2014-08-05 01:03:10]

https://codereview.chromium.org/440803002/diff/1/media/base/audio_splicer.cc
File media/base/audio_splicer.cc (left):

https://codereview.chromium.org/440803002/diff/1/media/base/audio_splicer.cc#...
media/base/audio_splicer.cc:305: if (pre_splice_sanitizer_->GetFrameCount() <=
On 2014/08/05 01:00:28, wolenetz wrote:
> I'm trying to grok which part of this condition previously led to the CHECK,
but
> doesn't in your patch set. What were the previous values of r
> pre_splice_sanitizer_->GetFrameCount() and
> output_ts_helper.GetFramesToTarget(splice_timestamp_) that led to the CHECK?

If frames_before_splice is negative this condition will never be true since
GetFrameCount() > 0.  See the other incorrect splice test cases in the unittest
for context on the rest of this condition.

[DaleCurtis, 2014-08-07 20:56:46]

Ping?

[wolenetz, 2014-08-07 23:12:12]

Sorry, it took a bit of time for me to get back to grokking this.

lgtm! The preponderance of badly encoded/muxed streams makes me sad.

https://codereview.chromium.org/440803002/diff/1/media/base/audio_splicer.cc
File media/base/audio_splicer.cc (left):

https://codereview.chromium.org/440803002/diff/1/media/base/audio_splicer.cc#...
media/base/audio_splicer.cc:305: if (pre_splice_sanitizer_->GetFrameCount() <=
On 2014/08/05 01:03:10, DaleCurtis wrote:
> On 2014/08/05 01:00:28, wolenetz wrote:
> > I'm trying to grok which part of this condition previously led to the CHECK,
> but
> > doesn't in your patch set. What were the previous values of r
> > pre_splice_sanitizer_->GetFrameCount() and
> > output_ts_helper.GetFramesToTarget(splice_timestamp_) that led to the CHECK?
> 
> If frames_before_splice is negative this condition will never be true since
> GetFrameCount() > 0.  See the other incorrect splice test cases in the
unittest
> for context on the rest of this condition.

Acknowledged.

[DaleCurtis, 2014-08-07 23:19:35]

The CQ bit was checked by dalecurtis@chromium.org

[commit-bot: I haz the power, 2014-08-08 00:01:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/440803002/1

[commit-bot: I haz the power, 2014-08-08 09:43:21]

Change committed as 288284