Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 440783004: Add support for all compressed formats in KTX file format (Closed)

Created:
6 years, 4 months ago by krajcevski
Modified:
6 years, 4 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add support for all compressed formats in KTX file format Committed: https://skia.googlesource.com/skia/+/40a1e11ebebe81586f3fec96408fdfd4b51123d2

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix boolean stuff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -10 lines) Patch
M gyp/ktx.gyp View 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/SkGr.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/images/SkImageDecoder_ktx.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M src/utils/SkTextureCompressor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/ktx/ktx.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/ktx/ktx.cpp View 1 2 chunks +31 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
krajcevski
6 years, 4 months ago (2014-08-05 15:45:35 UTC) #1
robertphillips
lgtm https://codereview.chromium.org/440783004/diff/1/third_party/ktx/ktx.cpp File third_party/ktx/ktx.cpp (right): https://codereview.chromium.org/440783004/diff/1/third_party/ktx/ktx.cpp#newcode151 third_party/ktx/ktx.cpp:151: if (fmt == SkTextureCompressor::kLATC_Format) { Why not just: ...
6 years, 4 months ago (2014-08-05 20:44:18 UTC) #2
krajcevski
https://codereview.chromium.org/440783004/diff/1/third_party/ktx/ktx.cpp File third_party/ktx/ktx.cpp (right): https://codereview.chromium.org/440783004/diff/1/third_party/ktx/ktx.cpp#newcode151 third_party/ktx/ktx.cpp:151: if (fmt == SkTextureCompressor::kLATC_Format) { On 2014/08/05 20:44:17, robertphillips ...
6 years, 4 months ago (2014-08-05 21:00:52 UTC) #3
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 4 months ago (2014-08-05 21:00:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/440783004/20001
6 years, 4 months ago (2014-08-05 21:01:19 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 21:13:40 UTC) #6
Message was sent while issue was closed. 
Change committed as 40a1e11ebebe81586f3fec96408fdfd4b51123d2

Powered by Google App Engine
This is Rietveld 408576698