Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Unified Diff: test/mjsunit/es6/debug-promises/reject-caught-uncaught.js

Issue 440773004: Trigger exception debug events on Promise reject. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/mjsunit/es6/debug-promises/reject-caught-uncaught.js
diff --git a/test/mjsunit/es6/debug-promises-caught-uncaught.js b/test/mjsunit/es6/debug-promises/reject-caught-uncaught.js
similarity index 58%
copy from test/mjsunit/es6/debug-promises-caught-uncaught.js
copy to test/mjsunit/es6/debug-promises/reject-caught-uncaught.js
index 2d44d2b88c66dfed3895b52d0ce891f87a94a842..d3fd9f3ae7add60586e810982d5881908d4312ae 100644
--- a/test/mjsunit/es6/debug-promises-caught-uncaught.js
+++ b/test/mjsunit/es6/debug-promises/reject-caught-uncaught.js
@@ -2,10 +2,10 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// Flags: --expose-debug-as debug
+// Flags: --expose-debug-as debug --allow-natives-syntax
// Test debug events when we only listen to uncaught exceptions and
-// there is a catch handler for the exception thrown in a Promise.
+// there is a catch handler for the to-be-rejected Promise.
// We expect no debug event to be triggered.
Debug = debug.Debug;
@@ -16,23 +16,19 @@ var p = new Promise(function(resolve, reject) {
var q = p.chain(
function() {
- throw new Error("caught");
+ return Promise.reject(Error("caught reject"));
});
q.catch(
function(e) {
- assertEquals("caught", e.message);
+ assertEquals("caught reject", e.message);
});
function listener(event, exec_state, event_data, data) {
try {
assertTrue(event != Debug.DebugEvent.Exception);
} catch (e) {
- // Signal a failure with exit code 1. This is necessary since the
- // debugger swallows exceptions and we expect the chained function
- // and this listener to be executed after the main script is finished.
- print("Unexpected exception: " + e + "\n" + e.stack);
- quit(1);
+ %AbortJS(e + "\n" + e.stack);
}
}
« no previous file with comments | « test/mjsunit/es6/debug-promises/reject-caught-late.js ('k') | test/mjsunit/es6/debug-promises/reject-in-constructor.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698