Index: chrome/browser/safe_browsing/module_integrity_verifier_win_unittest.cc |
diff --git a/chrome/browser/safe_browsing/module_integrity_verifier_win_unittest.cc b/chrome/browser/safe_browsing/module_integrity_verifier_win_unittest.cc |
index 0f0a7fcc581d92fe855cb08163698e9b696f1f44..d1e1f22029bfd86985dcd1952dce62f5f4106fdc 100644 |
--- a/chrome/browser/safe_browsing/module_integrity_verifier_win_unittest.cc |
+++ b/chrome/browser/safe_browsing/module_integrity_verifier_win_unittest.cc |
@@ -14,13 +14,6 @@ |
namespace safe_browsing { |
-namespace { |
- |
-const wchar_t kTestDllName[] = L"verifier_test_dll.dll"; |
-const char kTestExportName[] = "DummyExport"; |
- |
-} // namespace |
- |
class SafeBrowsingModuleVerifierTest : public testing::Test { |
protected: |
base::ScopedNativeLibrary mem_dll_handle_; |
@@ -44,12 +37,12 @@ class SafeBrowsingModuleVerifierTest : public testing::Test { |
void LoadModule() { |
mem_dll_handle_.Reset( |
- LoadNativeLibrary(base::FilePath(kTestDllName), NULL)); |
+ LoadNativeLibrary(base::FilePath(test_dll_names[0]), NULL)); |
ASSERT_TRUE(mem_dll_handle_.is_valid()); |
} |
void GetMemModuleHandle(HMODULE* mem_handle) { |
- *mem_handle = GetModuleHandle(kTestDllName); |
+ *mem_handle = GetModuleHandle(test_dll_names[0]); |
ASSERT_NE(static_cast<HMODULE>(NULL), *mem_handle); |
} |
@@ -94,14 +87,14 @@ TEST_F(SafeBrowsingModuleVerifierTest, VerifyModuleUnmodified) { |
std::set<std::string> modified_exports; |
// Call VerifyModule before the module has been loaded, should fail. |
EXPECT_EQ(MODULE_STATE_UNKNOWN, |
- VerifyModule(kTestDllName, &modified_exports)); |
+ VerifyModule(test_dll_names[0], &modified_exports)); |
EXPECT_EQ(0, modified_exports.size()); |
// On loading, the module should be identical (up to relocations) in memory as |
// on disk. |
SetUpTestDllAndPEImages(); |
EXPECT_EQ(MODULE_STATE_UNMODIFIED, |
- VerifyModule(kTestDllName, &modified_exports)); |
+ VerifyModule(test_dll_names[0], &modified_exports)); |
EXPECT_EQ(0, modified_exports.size()); |
} |
@@ -110,7 +103,7 @@ TEST_F(SafeBrowsingModuleVerifierTest, VerifyModuleModified) { |
// Confirm the module is identical in memory as on disk before we begin. |
SetUpTestDllAndPEImages(); |
EXPECT_EQ(MODULE_STATE_UNMODIFIED, |
- VerifyModule(kTestDllName, &modified_exports)); |
+ VerifyModule(test_dll_names[0], &modified_exports)); |
uint8_t* mem_code_addr = NULL; |
uint8_t* disk_code_addr = NULL; |
@@ -134,7 +127,7 @@ TEST_F(SafeBrowsingModuleVerifierTest, VerifyModuleModified) { |
// VerifyModule should detect the change. |
EXPECT_EQ(MODULE_STATE_MODIFIED, |
- VerifyModule(kTestDllName, &modified_exports)); |
+ VerifyModule(test_dll_names[0], &modified_exports)); |
} |
TEST_F(SafeBrowsingModuleVerifierTest, VerifyModuleExportModified) { |
@@ -142,14 +135,14 @@ TEST_F(SafeBrowsingModuleVerifierTest, VerifyModuleExportModified) { |
// Confirm the module is identical in memory as on disk before we begin. |
SetUpTestDllAndPEImages(); |
EXPECT_EQ(MODULE_STATE_UNMODIFIED, |
- VerifyModule(kTestDllName, &modified_exports)); |
+ VerifyModule(test_dll_names[0], &modified_exports)); |
modified_exports.clear(); |
// Edit the exported function, VerifyModule should now return the function |
// name in modified_exports. |
EditExport(); |
EXPECT_EQ(MODULE_STATE_MODIFIED, |
- VerifyModule(kTestDllName, &modified_exports)); |
+ VerifyModule(test_dll_names[0], &modified_exports)); |
EXPECT_EQ(1, modified_exports.size()); |
EXPECT_EQ(0, std::string(kTestExportName).compare(*modified_exports.begin())); |
} |