chrome/browser/safe_browsing/module_integrity_verifier_win.cc - Issue 440753002: The incident reporting service now calls VerifyModule.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/module_integrity_verifier_win.cc

Issue 440753002: The incident reporting service now calls VerifyModule. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/module_integrity_unittest_util_win.cc ('k') | chrome/browser/safe_browsing/module_integrity_verifier_win_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/module_integrity_verifier_win.cc

diff --git a/chrome/browser/safe_browsing/module_integrity_verifier_win.cc b/chrome/browser/safe_browsing/module_integrity_verifier_win.cc

index c8befe4059068b2afc6b6bd68deb66f6a60c8aa5..8478116b2d0805add6f705d5063bd3a13dfd937f 100644

--- a/chrome/browser/safe_browsing/module_integrity_verifier_win.cc

+++ b/chrome/browser/safe_browsing/module_integrity_verifier_win.cc

@@ -176,7 +176,7 @@ bool EnumRelocsCallback(const base::win::PEImage& mem_peimage,

// of relocations.

break;

default: {

- // TODO(krstnmnlsn): Find a reliable description of the behaviour of the

+ // TODO(robertshield): Find a reliable description of the behaviour of the

// remaining types of relocation and handle them.

state->unknown_reloc_type = true;

break;