The incident reporting service now calls VerifyModule.

chrome/browser/safe_browsing/module_integrity_verifier_win.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SAFE_BROWSING_MODULE_INTEGRITY_VERIFIER_WIN_H_
 #define CHROME_BROWSER_SAFE_BROWSING_MODULE_INTEGRITY_VERIFIER_WIN_H_
 
 #include <stdint.h>
 
 #include <set>
 
 namespace base {
 namespace win {
 class PEImage;
 class PEImageAsData;
 }  // namespace win
 }  // namespace base
 
 namespace safe_browsing {
 
+// The max number of test dlls in |test_dll_names|.

[csharp, 2014/08/05 15:46:33]

Lines 21->33 seem to be just for tests, can they be moved to a test file?

[grt (UTC plus 2), 2014/08/05 16:04:54]

yes, please move as much of this as possible into the _unittest.cc file(s) or a
module_integrity_unittest_util file(s) or something.

[krstnmnlsn, 2014/08/05 23:07:25]

Okay cool.  _util made.

+const int kTestDllsMaxCount = 5;

[grt (UTC plus 2), 2014/08/05 16:04:54]

i think this can be safely removed. there are ways to make the test not need a
value like this at compile time

[krstnmnlsn, 2014/08/05 23:07:25]

Done.

+
+// The test dlls used by module_integrity_verifier_win_unittest.cc and
+// environment_data_collection_win_unittest.cc.  The tests assume there exists
+// at least one entry.
+const wchar_t* test_dll_names[];
+
+// Returns the number of names in |test_dll_names|.
+int TestDllsCount();
+
+// A function exported by the test dlls in |test_dll_names|.
+const char kTestExportName[] = "DummyExport";
+
+// The max number of modules in |modules_to_verify|.
+const int kModulesToVerifyMaxCount = 5;
+
+// The modules on which we will run VerifyModule.
+const wchar_t* modules_to_verify[];
+
+// Returns the number of names in |modules_to_verify|.
+int ModulesToVerifyCount();
+
 // This enum defines the possible module states VerifyModule can return.
 enum ModuleState {
   MODULE_STATE_UNKNOWN,
   MODULE_STATE_UNMODIFIED,
   MODULE_STATE_MODIFIED,
 };
 
 // Helper to grab the addresses and size of the code section of a PEImage.
 // Returns two addresses: one for the dll loaded as a library, the other for the
 // dll loaded as data.
 bool GetCodeAddrsAndSize(const base::win::PEImage& mem_peimage,
                          const base::win::PEImageAsData& disk_peimage,
                          uint8_t** mem_code_addr,
                          uint8_t** disk_code_addr,
                          uint32_t* code_size);
 
 // Examines the code section of the given module in memory and on disk, looking
 // for unexpected differences.  Returns a ModuleState and and a set of the
 // possibly modified exports.
 ModuleState VerifyModule(const wchar_t* module_name,
                          std::set<std::string>* modified_exports);
 
 }  // namespace safe_browsing
 
 #endif  // CHROME_BROWSER_SAFE_BROWSING_MODULE_INTEGRITY_VERIFIER_WIN_H_