chrome/browser/safe_browsing/module_integrity_unittest_util_win.cc - Issue 440753002: The incident reporting service now calls VerifyModule.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/safe_browsing/module_integrity_unittest_util_win.cc

Issue 440753002: The incident reporting service now calls VerifyModule. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: the unittest_util files are back! Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/safe_browsing/environment_data_collection_win_unittest.cc ('K') | « chrome/browser/safe_browsing/module_integrity_unittest_util_win.h ('k') | chrome/browser/safe_browsing/module_integrity_verifier_win_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/safe_browsing/module_integrity_unittest_util_win.h"

	6

	7 #include "base/macros.h"

	8

	9 namespace safe_browsing {

	10

	11 const wchar_t* const kTestDllNames[] = {

	12 L"verifier_test_dll_1.dll",

	13 L"verifier_test_dll_2.dll",

	14 NULL,

	15 };

	16

	17 size_t kTestDllNamesCount = arraysize(kTestDllNames) - 1;
	csharp 2014/08/07 17:22:12 Nit: Might be worth adding a short comment remindi Nit: Might be worth adding a short comment reminding readers that the -1 here is because you mark the end of the array with a NULL value, which isn't a name we want to examine krstnmnlsn 2014/08/07 21:21:22 Done. Show quoted text On 2014/08/07 17:22:12, csharp wrote: > Nit: Might be worth adding a short comment reminding readers that the -1 here is > because you mark the end of the array with a NULL value, which isn't a name we > want to examine Done.
	18

	19 const char kTestExportName[] = "DummyExport";

	20

	21 } // namespace safe_browsing

OLD	NEW