Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 440733002: Make adjustStyleForTagName take a HTMLElement parameter (Closed)

Created:
6 years, 4 months ago by rwlbuis
Modified:
6 years ago
Reviewers:
esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Make adjustStyleForTagName take a HTMLElement parameter Make adjustStyleForTagName take a HTMLElement parameter since it only tests for HTMLElements. Besides being more clear, this avoids the ~10 checks for isHTMLElement in the isHTML helpers. To make this more clear rename to adjustStyleForHTMLElement. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187309

Patch Set 1 #

Patch Set 2 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M Source/core/css/resolver/StyleAdjuster.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleAdjuster.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
rwlbuis
PTAL
6 years ago (2014-12-16 21:42:18 UTC) #2
esprehn
lgtm, you might rename adjustStyleForTagName to adjustStyleForHTMLElement?
6 years ago (2014-12-16 23:18:34 UTC) #3
rwlbuis
On 2014/12/16 23:18:34, esprehn wrote: > lgtm, you might rename adjustStyleForTagName to adjustStyleForHTMLElement? Good point, ...
6 years ago (2014-12-16 23:19:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/440733002/20001
6 years ago (2014-12-16 23:24:55 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-17 00:42:45 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187309

Powered by Google App Engine
This is Rietveld 408576698