Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 440713005: Change the title of the desktop User Manager widget. (Closed)

Created:
6 years, 4 months ago by noms (inactive)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, tfarina, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Change the title of the desktop User Manager widget. The title of the window widget should be the product name (Chrome/Chromium). Added a "close" button to make the last bubble in the tutorial dismissible. BUG=399698, 399697 TEST=Start Chrome with --new-avatar-menu. Choose "Switch person" from the avatar menu of a brand new profile. Once you go through all the slides in the tutorial, the last bubble which points to the "Add Person" button should have a little x button in the top right corner. Also, the title of the window should be "Chrome". Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288385

Patch Set 1 #

Total comments: 4

Patch Set 2 : remove useless includes #

Patch Set 3 : fix browser test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -13 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/user_manager/user_manager_tutorial.css View 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/resources/user_manager/user_manager_tutorial.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/user_manager/user_manager_tutorial.js View 2 chunks +11 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/user_manager_mac.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/profiles/user_manager_view.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/signin/user_manager_screen_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/signin/user_manager_ui_browsertest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
noms (inactive)
+ Pavel for chrome/browser/resources/* and generated_resources.grd + Mike for chrome/browser/ui/*
6 years, 4 months ago (2014-08-04 18:22:54 UTC) #1
msw
c/b/ui lgtm with extra includes removed. https://codereview.chromium.org/440713005/diff/1/chrome/browser/ui/cocoa/profiles/user_manager_mac.mm File chrome/browser/ui/cocoa/profiles/user_manager_mac.mm (right): https://codereview.chromium.org/440713005/diff/1/chrome/browser/ui/cocoa/profiles/user_manager_mac.mm#newcode17 chrome/browser/ui/cocoa/profiles/user_manager_mac.mm:17: #include "grit/generated_resources.h" You ...
6 years, 4 months ago (2014-08-04 20:17:56 UTC) #2
dzhioev (left Google)
LTGM, but I am not in OWNERS of chrome/browser/resources
6 years, 4 months ago (2014-08-05 12:58:33 UTC) #3
noms (inactive)
+ nikita for owners stamp on chrome/browser/resources
6 years, 4 months ago (2014-08-06 18:33:10 UTC) #4
noms (inactive)
https://codereview.chromium.org/440713005/diff/1/chrome/browser/ui/cocoa/profiles/user_manager_mac.mm File chrome/browser/ui/cocoa/profiles/user_manager_mac.mm (right): https://codereview.chromium.org/440713005/diff/1/chrome/browser/ui/cocoa/profiles/user_manager_mac.mm#newcode17 chrome/browser/ui/cocoa/profiles/user_manager_mac.mm:17: #include "grit/generated_resources.h" On 2014/08/04 20:17:55, msw wrote: > You ...
6 years, 4 months ago (2014-08-06 18:41:24 UTC) #5
noms (inactive)
Nikita: ping! :)
6 years, 4 months ago (2014-08-08 04:11:35 UTC) #6
Nikita (slow)
lgtm
6 years, 4 months ago (2014-08-08 12:53:51 UTC) #7
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 4 months ago (2014-08-08 13:29:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/440713005/20001
6 years, 4 months ago (2014-08-08 13:30:17 UTC) #9
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 4 months ago (2014-08-08 15:04:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/440713005/40001
6 years, 4 months ago (2014-08-08 15:05:35 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 17:19:49 UTC) #12
Message was sent while issue was closed.
Change committed as 288385

Powered by Google App Engine
This is Rietveld 408576698