Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 440713002: Use SVGElement as parameter for isDirectReference (Closed)

Created:
6 years, 4 months ago by rwlbuis
Modified:
6 years, 4 months ago
CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Use SVGElement as parameter for isDirectReference It is a bit more efficient to use SVGElement for the isSVG checks, so make isDirectReference take a SVGElement parameter. Also add an early return in SVGUseElement::toClipPath. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179515

Patch Set 1 : #

Patch Set 2 : V2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M Source/core/svg/SVGUseElement.cpp View 1 3 chunks +15 lines, -14 lines 0 comments Download

Messages

Total messages: 26 (0 generated)
rwlbuis
PTAL
6 years, 4 months ago (2014-08-04 19:19:48 UTC) #1
kouhei (in TOK)
lgtm
6 years, 4 months ago (2014-08-04 19:22:02 UTC) #2
rwlbuis
@Chris, PTAL, the new patch just calls renderer() on a plain old Node.
6 years, 4 months ago (2014-08-04 23:04:27 UTC) #3
Inactive
lgtm
6 years, 4 months ago (2014-08-04 23:31:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/440713002/40001
6 years, 4 months ago (2014-08-04 23:32:29 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-05 00:39:12 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 00:46:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20693)
6 years, 4 months ago (2014-08-05 00:46:05 UTC) #8
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 4 months ago (2014-08-05 01:13:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/440713002/40001
6 years, 4 months ago (2014-08-05 01:13:59 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-05 01:55:06 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 02:58:17 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20716)
6 years, 4 months ago (2014-08-05 02:58:18 UTC) #13
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 4 months ago (2014-08-05 03:00:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/440713002/40001
6 years, 4 months ago (2014-08-05 03:01:03 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-05 04:02:28 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 04:10:07 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20741)
6 years, 4 months ago (2014-08-05 04:10:08 UTC) #18
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 4 months ago (2014-08-05 11:32:19 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/440713002/40001
6 years, 4 months ago (2014-08-05 11:34:00 UTC) #20
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-05 13:00:40 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 13:55:11 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20919)
6 years, 4 months ago (2014-08-05 13:55:12 UTC) #23
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 4 months ago (2014-08-05 17:08:20 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/440713002/40001
6 years, 4 months ago (2014-08-05 17:10:23 UTC) #25
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 19:06:01 UTC) #26
Message was sent while issue was closed.
Change committed as 179515

Powered by Google App Engine
This is Rietveld 408576698