Issue 440703002: Replace "using namespace" statement with individual "using" statements

Issue 440703002: Replace "using namespace" statement with individual "using" statements (Closed)

Created:
6 years, 4 months ago by mdempsky

Modified:
6 years, 4 months ago

Reviewers:
Mark Seaborn

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Replace "using namespace" statement with individual "using" statements BUG=375497 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287460

Patch Set 2 : Fix typo #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
	M	components/nacl/loader/nonsfi/nonsfi_sandbox.cc	View	1	1 chunk	+10 lines, -1 line	0 comments	Download
	M	sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Mark Seaborn

LGTM, thanks https://codereview.chromium.org/440703002/diff/1/components/nacl/loader/nonsfi/nonsfi_sandbox.cc File components/nacl/loader/nonsfi/nonsfi_sandbox.cc (right): https://codereview.chromium.org/440703002/diff/1/components/nacl/loader/nonsfi/nonsfi_sandbox.cc#newcode41 components/nacl/loader/nonsfi/nonsfi_sandbox.cc:41: // be resolved via argument-dependant lookup. "dependent"

6 years, 4 months ago (2014-08-04 19:44:58 UTC) #2

mdempsky

https://codereview.chromium.org/440703002/diff/1/components/nacl/loader/nonsfi/nonsfi_sandbox.cc File components/nacl/loader/nonsfi/nonsfi_sandbox.cc (right): https://codereview.chromium.org/440703002/diff/1/components/nacl/loader/nonsfi/nonsfi_sandbox.cc#newcode41 components/nacl/loader/nonsfi/nonsfi_sandbox.cc:41: // be resolved via argument-dependant lookup. On 2014/08/04 19:44:58, ...

6 years, 4 months ago (2014-08-04 20:01:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mdempsky@chromium.org/440703002/20001

6 years, 4 months ago (2014-08-04 20:03:26 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...

6 years, 4 months ago (2014-08-04 21:16:21 UTC) #6

Message was sent while issue was closed.

Change committed as 287460

Expand Messages | Collapse Messages