Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 440693002: Add function to register a synthetic trial with the trial hash. (Closed)

Created:
6 years, 4 months ago by Alexei Svitkine (slow)
Modified:
6 years, 4 months ago
Reviewers:
jwd
CC:
chromium-reviews, Ilya Sherman, asvitkine+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add function to register a synthetic trial with the trial hash. This will be used by Android Chrome to register external experiments. BUG=400357 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287695

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -19 lines) Patch
M chrome/browser/metrics/chrome_metrics_service_accessor.h View 1 3 chunks +12 lines, -2 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_accessor.cc View 1 2 chunks +13 lines, -3 lines 0 comments Download
M chrome/browser/metrics/metrics_service_accessor.h View 1 2 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/metrics/metrics_service_accessor.cc View 1 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Alexei Svitkine (slow)
6 years, 4 months ago (2014-08-04 17:26:28 UTC) #1
Alexei Svitkine (slow)
ping
6 years, 4 months ago (2014-08-05 16:45:03 UTC) #2
jwd
https://codereview.chromium.org/440693002/diff/20001/chrome/browser/metrics/metrics_service_accessor.h File chrome/browser/metrics/metrics_service_accessor.h (right): https://codereview.chromium.org/440693002/diff/20001/chrome/browser/metrics/metrics_service_accessor.h#newcode36 chrome/browser/metrics/metrics_service_accessor.h:36: // in must not correspond to any real field ...
6 years, 4 months ago (2014-08-05 19:26:05 UTC) #3
Alexei Svitkine (slow)
https://codereview.chromium.org/440693002/diff/20001/chrome/browser/metrics/metrics_service_accessor.h File chrome/browser/metrics/metrics_service_accessor.h (right): https://codereview.chromium.org/440693002/diff/20001/chrome/browser/metrics/metrics_service_accessor.h#newcode36 chrome/browser/metrics/metrics_service_accessor.h:36: // in must not correspond to any real field ...
6 years, 4 months ago (2014-08-05 19:31:41 UTC) #4
jwd
lgtm
6 years, 4 months ago (2014-08-05 19:36:47 UTC) #5
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 4 months ago (2014-08-05 19:37:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/440693002/40001
6 years, 4 months ago (2014-08-05 19:39:16 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-05 23:58:10 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 00:22:54 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/3002)
6 years, 4 months ago (2014-08-06 00:22:55 UTC) #10
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 4 months ago (2014-08-06 03:54:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/440693002/40001
6 years, 4 months ago (2014-08-06 03:57:07 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 06:03:25 UTC) #13
Message was sent while issue was closed. 
Change committed as 287695

Powered by Google App Engine
This is Rietveld 408576698