Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 440683004: Move the user agent styles sheets to blink_resources.grd (Part 1) with conditional includes (Closed)

Created:
6 years, 4 months ago by vivekg_samsung
Modified:
6 years, 4 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Move the user agent styles sheets to blink_resources.grd (Part 1) with conditional includes This is continuation to earlier CL [1] with the conditional statements being added for specific platform CSS file includes. Part 1: https://codereview.chromium.org/436843004/ Part 2: https://codereview.chromium.org/422023008/ Part 3: https://codereview.chromium.org/438843004/ BUG=312586 NOTRY=true TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179504

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M public/blink_resources.grd View 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
vivekg
PTAL, thank you
6 years, 4 months ago (2014-08-04 15:05:31 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 4 months ago (2014-08-05 09:05:04 UTC) #2
vivekg
The CQ bit was checked by vivekg@chromium.org
6 years, 4 months ago (2014-08-05 09:11:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/440683004/20001
6 years, 4 months ago (2014-08-05 09:12:04 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-05 15:01:50 UTC) #5
vivekg
The CQ bit was unchecked by vivekg@chromium.org
6 years, 4 months ago (2014-08-05 15:23:14 UTC) #6
vivekg
The CQ bit was checked by vivekg@chromium.org
6 years, 4 months ago (2014-08-05 15:23:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/440683004/20001
6 years, 4 months ago (2014-08-05 15:23:59 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 15:25:28 UTC) #9
Message was sent while issue was closed.
Change committed as 179504

Powered by Google App Engine
This is Rietveld 408576698