Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 440673003: Rename a prefixed fullscreen test to full-screen-* for consistency (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
Reviewers:
falken
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Rename a prefixed fullscreen test to full-screen-* for consistency This way, fullscreen-* can be used for the unprefixed API tests. BUG=383813 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179511

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -35 lines) Patch
A + LayoutTests/fullscreen/full-screen-child-not-allowed-crash.html View 2 chunks +3 lines, -3 lines 0 comments Download
A + LayoutTests/fullscreen/full-screen-child-not-allowed-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/fullscreen/fullscreen-child-not-allowed-crash.html View 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/fullscreen/fullscreen-child-not-allowed-crash-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
philipj_slow
PTAL
6 years, 4 months ago (2014-08-04 12:38:39 UTC) #1
falken
On 2014/08/04 12:38:39, philipj wrote: > PTAL LGTM
6 years, 4 months ago (2014-08-05 04:59:08 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-08-05 05:25:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/440673003/1
6 years, 4 months ago (2014-08-05 05:26:12 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-05 05:48:28 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 06:09:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/19543)
6 years, 4 months ago (2014-08-05 06:09:14 UTC) #7
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-08-05 07:35:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/440673003/1
6 years, 4 months ago (2014-08-05 07:36:45 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-05 08:24:31 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 17:07:07 UTC) #11
Message was sent while issue was closed.
Change committed as 179511

Powered by Google App Engine
This is Rietveld 408576698