Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 440663004: Add V-bates to Chrome's Browser's blacklist (Closed)

Created:
6 years, 4 months ago by csharp
Modified:
6 years, 4 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, caitkp+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add V-bates to Chrome's Browser's blacklist BUG=399744 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287546

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome_elf/blacklist/blacklist.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
csharp
6 years, 4 months ago (2014-08-04 17:46:57 UTC) #1
robertshield
lgtm
6 years, 4 months ago (2014-08-04 17:48:14 UTC) #2
csharp
The CQ bit was checked by csharp@chromium.org
6 years, 4 months ago (2014-08-04 17:48:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/440663004/1
6 years, 4 months ago (2014-08-04 17:48:49 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-04 21:11:03 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-04 21:14:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/1921)
6 years, 4 months ago (2014-08-04 21:14:41 UTC) #7
csharp
Alexei, can you provide an owner's review for the change to the histogram file?
6 years, 4 months ago (2014-08-05 15:28:18 UTC) #8
Alexei Svitkine (slow)
lgtm
6 years, 4 months ago (2014-08-05 15:31:49 UTC) #9
csharp
The CQ bit was checked by csharp@chromium.org
6 years, 4 months ago (2014-08-05 15:36:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/440663004/1
6 years, 4 months ago (2014-08-05 15:36:52 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 15:41:29 UTC) #12
Message was sent while issue was closed.
Change committed as 287546

Powered by Google App Engine
This is Rietveld 408576698