Issue 440663002: Enable C++11. Synch toolchains with Chrome.

Issue 440663002: Enable C++11. Synch toolchains with Chrome. (Closed)

Created:
6 years, 4 months ago by Sven Panne

Modified:
6 years, 4 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Enable C++11. Synch toolchains with Chrome. * Consistently enable C++11 features on all platforms. * Use the same ARM toolchain version as Chrome. * Make clang the default on Mac OS X, just like Chrome. * Use C99 on Mac OS X, again following Chrome. * Small build fixes. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22875

Patch Set 1 #

Total comments: 1

Patch Set 2 #

Patch Set 3 : Fixed Android compilation. Fixed a warning. #

Patch Set 4 : Disabled test on VisualStudio for now. #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -12 lines)			Patch
M	Makefile.android	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	build/android.gypi	View	1 2	1 chunk	+6 lines, -1 line	0 comments	Download
M	build/standalone.gypi	View	1 2	6 chunks	+9 lines, -8 lines	0 comments	Download
M	src/base/platform/platform-posix.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/json-parser.h	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	test/cctest/test-utils.cc	View	1 2 3	2 chunks	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

https://codereview.chromium.org/440663002/diff/1/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/440663002/diff/1/build/standalone.gypi#newcode217 build/standalone.gypi:217: 'cflags_cc': [ '-Wnon-virtual-dtor', '-fno-rtti', '-std=c++0x' ], why not c++11?

6 years, 4 months ago (2014-08-04 09:02:36 UTC) #1

Sven Panne

On 2014/08/04 09:02:36, jochen wrote: > https://codereview.chromium.org/440663002/diff/1/build/standalone.gypi > File build/standalone.gypi (right): > > https://codereview.chromium.org/440663002/diff/1/build/standalone.gypi#newcode217 > ...

6 years, 4 months ago (2014-08-04 09:12:35 UTC) #2

Sven Panne

Tests disabled on Windows for now (until bots are fixed), at least we get the ...

6 years, 4 months ago (2014-08-05 12:13:05 UTC) #3

Sven Panne

6 years, 4 months ago (2014-08-05 13:24:04 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as 22875 (presubmit successful).

Expand Messages | Collapse Messages