Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 440643004: Don't call out -lstdc++ -lm explicitly. (Closed)

Created:
6 years, 4 months ago by mtklein_C
Modified:
6 years, 4 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Don't call out -lstdc++ -lm explicitly. BUG=skia: Committed: https://skia.googlesource.com/skia/+/bce540ca8fb23c1a99f4216cc5ecae46c722dafa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M gyp/common_conditions.gypi View 3 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
6 years, 4 months ago (2014-08-04 17:39:05 UTC) #1
bungeman-skia
So long as everything keeps working, lgtm.
6 years, 4 months ago (2014-08-04 17:40:32 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-04 17:40:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/440643004/1
6 years, 4 months ago (2014-08-04 17:41:47 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-04 18:10:22 UTC) #5
Message was sent while issue was closed.
Change committed as bce540ca8fb23c1a99f4216cc5ecae46c722dafa

Powered by Google App Engine
This is Rietveld 408576698