[Mac] Use CommonTheme for the new avatar menu button hover background

chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #import "chrome/browser/ui/cocoa/profiles/profile_chooser_controller.h"
 
 #include "base/mac/bundle_locations.h"
 #include "base/prefs/pref_service.h"
@@ skipping 42 matching lines @@
 #import "ui/base/cocoa/cocoa_base_utils.h"
 #import "ui/base/cocoa/controls/blue_label_button.h"
 #import "ui/base/cocoa/controls/hyperlink_button_cell.h"
 #import "ui/base/cocoa/hover_image_button.h"
 #include "ui/base/cocoa/window_size_constants.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/l10n/l10n_util_mac.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/image/image.h"
 #include "ui/gfx/text_elider.h"
+#include "ui/native_theme/common_theme.h"
 #include "ui/native_theme/native_theme.h"
 
 namespace {
 
 // Constants taken from the Windows/Views implementation at:
 // chrome/browser/ui/views/profile_chooser_view.cc
 const int kLargeImageSide = 88;
 const int kSmallImageSide = 32;
 const CGFloat kFixedMenuWidth = 250;
 
@@ skipping 104 matching lines @@
   frame.origin = frame_origin;
   [text_view setFrame:frame];
   [text_view setDelegate:delegate];
   return text_view.autorelease();
 }
 
 // Returns the native dialog background color.
 NSColor* GetDialogBackgroundColor() {
   return gfx::SkColorToCalibratedNSColor(
       ui::NativeTheme::instance()->GetSystemColor(
           ui::NativeTheme::kColorId_DialogBackground));

[tapted, 2014/08/04 03:11:47]

note, I might be looking to change this later too.. But I'll change them all at
once. Something like kColorId_MenuBackgroundColor might be suitable here.

[groby-ooo-7-16, 2014/08/06 00:05:25]

It'd be nice if the theme called out a color id for dialog backgrounds. (Not
that it matters to this CL)

[tapted, 2014/08/06 01:49:08]

Maybe a separate colors for NSAlert-style dialog backgrounds, and another for
bubble-like backgrounds is in order.

I'll probably end up getting some input from a UX person. The constant that
NativeThemeMac offers up is quite white. I think, e.g., the bookmark bubble
looks a bit out of place on Mac. On Linux, it's nice shade of gray that matches
the toolbar background.

Checking iTunes.. it has some bubbles that you get from its _two_ hotdog buttons
(one in the status display that only appears on hover). One is quite gray, and
one is quite white.  So, I guess that's not much help :/. 

One of my many yaks to shave...

[groby-ooo-7-16, 2014/08/07 00:37:09]

I <3 yaks! ;)

In that vein - maybe there should be a CommonBubbleTheme, and a
CommonDialogTheme? It'd be nice to have those constants centralized.

 }
 
 // Builds a title card with one back button right aligned and one label center
 // aligned.
 NSView* BuildTitleCard(NSRect frame_rect,
                        int message_id,
                        id back_button_target,
                        SEL back_button_action) {
   base::scoped_nsobject<NSView> container(
       [[NSView alloc] initWithFrame:frame_rect]);
@@ skipping 437 matching lines @@
 }
 @end
 
 @implementation BackgroundColorHoverButton
 
 - (id)initWithFrame:(NSRect)frameRect
   imageTitleSpacing:(int)imageTitleSpacing
     backgroundColor:(NSColor*)backgroundColor {
   if ((self = [super initWithFrame:frameRect])) {
     backgroundColor_.reset([backgroundColor retain]);
-    hoverColor_.reset([gfx::SkColorToCalibratedNSColor(
-        ui::NativeTheme::instance()->GetSystemColor(
-            ui::NativeTheme::kColorId_ButtonHoverBackgroundColor)) retain]);
+    // Use a color from the common theme, since this button is not trying to
+    // look like a native control.
+    SkColor hoverColor;
+    bool found = ui::CommonThemeGetSystemColor(
+        ui::NativeTheme::kColorId_ButtonHoverBackgroundColor, &hoverColor);

[groby-ooo-7-16, 2014/08/06 00:05:25]

I wish CommonTheme followed the NativeTheme API and didn't return a bool :(

[tapted, 2014/08/06 01:49:09]

Yeah :/ - I think it's to avoid something special to handle SkColor(0), although
100% transparent black is a pretty useless colour (and the SystemColor tests
I've added treat it as an error anyway).

+    DCHECK(found);
+    hoverColor_.reset([gfx::SkColorToSRGBNSColor(hoverColor) retain]);

[tapted, 2014/08/04 03:11:47]

Note it's using sRGB rather than "Calibrated" here. sRGB is the colorspace that
PNGs, CSS, iOS and Windows use by default [more info: http://crbug.com/254361 ].
This might be darker than previously -- sRGB values are encoded with a gamma of
2.2 which became the default in Snow Leopard [1], but older NSColor methods tend
to use a gamma of 1.8.

Seems NSColor documentation [2] now also recommends srgb: "Where possible, it is
preferable to specify the colorspace explicitly using the
colorWithSRGBRed:green:blue:alpha: or colorWithGenericGamma22White:alpha:
method."

[1] http://support.apple.com/kb/ht3712
[2]
https://developer.apple.com/library/mac/documentation/cocoa/Reference/Applica...:

[groby-ooo-7-16, 2014/08/06 00:05:24]

+1 on fixing the color space. (I believe I suggested "calibrated" here, so
that's my fault)

But N.B. that half of our colors still use SkColorToCalibratedNSColor. Not
directly relevant to the bug, but should we add a presubmit that prevents use of
calibrated?

[tapted, 2014/08/06 01:49:09]

Good idea - I think something like https://codereview.chromium.org/448483003
will do this, but I'll start some discussions first (and update the
cocoa-dos-and-don'ts page). There was some uncertainty when it came up before.
However, since the NSColor documentation has been updated to suggest srgb over
other methods, I think it's more clear.

 
     [self setBordered:NO];
     [self setFont:[NSFont labelFontOfSize:kTextFontSize]];
     [self setButtonType:NSMomentaryChangeButton];
 
     base::scoped_nsobject<CustomPaddingImageButtonCell> cell(
         [[CustomPaddingImageButtonCell alloc]
             initWithLeftMarginSpacing:kHorizontalSpacing
                     imageTitleSpacing:imageTitleSpacing]);
     [cell setLineBreakMode:NSLineBreakByTruncatingTail];
@@ skipping 1233 matching lines @@
 
   return button.autorelease();
 }
 
 - (void)postActionPerformed:(ProfileMetrics::ProfileDesktopMenu)action {
   ProfileMetrics::LogProfileDesktopMenu(action, serviceType_);
   serviceType_ = signin::GAIA_SERVICE_TYPE_NONE;
 }
 
 @end