Issue 440603002: Put back the standard-layout checks lost in 5bbb7e8abbe0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 440603002: Put back the standard-layout checks lost in 5bbb7e8abbe0 (Closed)

Created:
6 years, 4 months ago by Mark Mentovai

Modified:
6 years, 4 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

Put back the standard-layout checks lost in 5bbb7e8abbe0. TEST=util_test UUID.UUID R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/4ae57690fa1a

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -0 lines)			Patch
M	util/misc/uuid.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	util/misc/uuid.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	util/misc/uuid_test.cc	View	1 chunk	+15 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Mark Mentovai

I realized that we still rely on standard layout and these checks should not have ...

6 years, 4 months ago (2014-08-03 15:11:26 UTC) #1

Mark Mentovai

6 years, 4 months ago (2014-08-03 22:50:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 4ae57690fa1a (presubmit successful).